Extend precompile to support a DAG #792
Draft
+164
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian H <[email protected]>
|
/cc @jprendes as well who is doing some larger changes to the engine linking a few issues for context: |
jsturtevant
reviewed
Jan 9, 2025
| @@ -62,7 +65,7 @@ pub trait Engine: Clone + Send + Sync + 'static { | |||
| /// The cached, precompiled layers will be reloaded on subsequent runs. | |||
| /// The runtime is expected to return the same number of layers passed in, if the layer cannot be precompiled it should return `None` for that layer. | |||
| /// In some edge cases it is possible that the layers may already be precompiled and None should be returned in this case. | |||
| fn precompile(&self, _layers: &[WasmLayer]) -> Result<Vec<Option<Vec<u8>>>> { | |||
| async fn precompile(&self, _layers: &[WasmLayer]) -> Result<Vec<PrecompiledLayer>> { | |||
There was a problem hiding this comment.
Since this now provides a way to do more than just pre-compiling such as composing I wonder if we would want to rename it
There was a problem hiding this comment.
Yeah that definitely seems reasonable! Happy to call this process_layers or whatever makes sense.
|
a quick look and it is about what I was expecting for changes. It was helpful to see how it was used in a non trivial example with spinkube/containerd-shim-spin#259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP while I address some lingering TODOs but wanted to get this up for 👀 before too long.
This PR effectively breaks the assumption that layers input to precompile map 1:1 with layers returned. This is necessary to support things like component dependencies in the spin shim via composition where there is not a clear mapping of original to precompiled layers.
I tried to evolve the precompile API in the most straightforward way without requiring shim developers to have to manage a DAG themselves.
NOTE: have to update the other shims to conform to the new API which will be straightforward but i'd like to get feedback on this approach here first.
cc/ @Mossaka @jsturtevant @kate-goldenring