Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process not found should not return ok #313

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Process not found should not return ok #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions crates/runc-shim/src/container.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ where
let process = self.get_mut_process(exec_id_opt);
match process {
Ok(p) => p.delete().await?,
Err(Error::NotFoundError(_)) => return Ok((pid, code, exited_at)),
Err(e) => return Err(e),
}
if let Some(exec_id) = exec_id_opt {
Expand Down Expand Up @@ -228,7 +227,7 @@ where
match exec_id {
Some(exec_id) => {
let p = self.processes.get_mut(exec_id).ok_or_else(|| {
Error::NotFoundError("can not find the exec by id".to_string())
Error::NotFoundError(format!("can not find the exec by id {}", exec_id))
})?;
Ok(p)
}
Expand Down
Loading