Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove O_NONBLOCK. #356

Closed
wants to merge 0 commits into from
Closed

Remove O_NONBLOCK. #356

wants to merge 0 commits into from

Conversation

analytically
Copy link

O_NONBLOCK on stdin is actually causing issues when reading. When we try to read from stdin (like with cat), it's failing immediately with EAGAIN ("Resource temporarily unavailable") because there's no data immediately available.

For stdin, we typically want blocking behavior because:

  • The reader (like cat) expects to be able to block waiting for input
  • There's no risk of deadlock on the open operation for stdin since we're opening an already-existing FIFO

Closes #353

@github-actions github-actions bot added the C-runc runc helper label Jan 6, 2025
@analytically
Copy link
Author

@mxpv

@mxpv
Copy link
Member

mxpv commented Jan 6, 2025

I've fixed the CI in main, could you pls rebase your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-runc runc helper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using rust-extensions makes stdin non-blocking?
2 participants