Add tests with the latest unreleased (a.k.a master) containerd
#257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#253
Currently, the snapshotter is tested with the latest released containerd (currently v1.4.3).
However, it's not enough from the snapshotter user's perspective as they possibly pick un-released (sometimes the latest) version of containerd and they need to make sure that this snapshotter plugin works with that version of containerd.
Though it's not easy to test snapshotter with arbitrary versions & commits of containerd, we should at least catch up changes on containerd closely and quickly fix snapshotter or containerd when some of the recent changes on containerd cause incompatibility.
This commit helps this by adding the following tests:
In the future, we should run integration tests in containerd/containerd's CI on each PR. This will make sure that each commit merged into containerd/containerd works with stargz snapshotter. Additionally, the snapshotter user can pick (at least) one commit of stargz snaphotter that is tested with the containerd version (commit) they'll use.