Implement remote snapshotter as a proxy plugin #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Dec 12, 2019
| [proxy_plugins] | ||
| [proxy_plugins.remote] | ||
| type = "snapshot" | ||
| address = "/var/lib/rs/rs.sock" |
There was a problem hiding this comment.
nit: socks are typically located under /run
There was a problem hiding this comment.
Thank you for your review. I'll fix it on the next commit.
ktock
added a commit
that referenced
this pull request
Jan 7, 2020
Implement remote snapshotter as a proxy plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables us to use remote snapshotter as a containerd proxy plugin. So we can bundle remote snapshotter and filesystem plugins in one container and plug it to containerd.
For more detail about containerization, see docker-compose.yml and this docker context .
We've already been able to specify the priority of filesystem plugins since 26f211b, so all issues mentioned in containerd/containerd#3731 (comment) have solved.
cc: @jblomer @siscia