Alias generate systemd options stop_timeout and time
#685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes containers#683 Option `time` was used before Podman v4, then it was renamed `stop_timeout`. Accept both names (the newer takes prirority) and set the correct CLI argument name based on the detected Podman version. Signed-off-by: Alessandro Fulgini <[email protected]>
sshnaidm
reviewed
Dec 3, 2023
Signed-off-by: Alessandro Fulgini <[email protected]>
sshnaidm
reviewed
Dec 4, 2023
Co-authored-by: Sergey <[email protected]>
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #683
The spec of the
podman generate systemdcommand has changed between v3 and v4.Option
timewas used before Podman v4 (manpage), then it has been renamedstop-timeout(manpage).Problems with this change have also been reported in #675.
The proposed change is to accept both names (the newer takes prirority) and set the correct CLI argument name based on the detected Podman version.
In this way, the user doesn't have to implement a different behavior based on the detected Podman version.
The change involves modules
podman_containerandpodman_pod.