docs(podman_container): improve comments on network property #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkhashimoto
force-pushed
the
docs/container-network
branch
3 times, most recently
from
186b13c to
5789a02
Compare
|
Oops, fixed the tests :) |
sshnaidm
requested changes
Nov 24, 2024
vkhashimoto
force-pushed
the
docs/container-network
branch
4 times, most recently
from
fbe4552 to
fc03f80
Compare
Signed-off-by: vkhashimoto <[email protected]>
vkhashimoto
force-pushed
the
docs/container-network
branch
from
fc03f80 to
1ae8a1c
Compare
|
@sshnaidm I've addressed all your comments and I'm only changing the description itself. |
sshnaidm
approved these changes
Nov 24, 2024
|
Thanks, looks much better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #877