Handle EINTR #657
Comments
smcv
added a commit
to smcv/bubblewrap
that referenced
this issue
Oct 3, 2024
This will allow it to be used in more places. Helps: containers#657 Signed-off-by: Simon McVittie <[email protected]>
smcv
added a commit
to smcv/bubblewrap
that referenced
this issue
Oct 3, 2024
If a blocking operation is interrupted by a signal, including SIGCHLD, various things can fail with EINTR. This is not a "real" error and can result in spurious failures. Resolves: containers#657 Signed-off-by: Simon McVittie <[email protected]>
smcv
added a commit
to smcv/bubblewrap
that referenced
this issue
Oct 3, 2024
This will allow it to be used in more places. Helps: containers#657 Signed-off-by: Simon McVittie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In WebKit/WebKit#34268 we discovered that some code I copied from bubblewrap is not properly handling EINTR, specifically the calls to sendmsg() and recvmsg() in utils.c.
I had considered submitting a quick pull request, but quickly discovered these aren't the only places. E.g. the call to openat() in load_file_at() in utils.c has the same problem. Unfortunately there's no easy way to check a large codebase for places with missing error handling.
The text was updated successfully, but these errors were encountered: