tests: use stat -c instead of --format for compatibility #627
Conversation
There was a problem hiding this comment.
The change looks fine. Please add a Signed-off-by to indicate your acceptance of https://developercertificate.org/ as described in https://github.com/containers/common/blob/main/CONTRIBUTING.md#sign-your-prs.
|
Ok, done |
|
@alexlarsson, @cgwalters: Please confirm whether you are intending to enforce the rule that This PR and #618 are both blocked by having a decision on that. I would personally be fine with a pseudonymous Signed-off-by, especially for small contributions - but I didn't write the rule, so I don't feel that I can be the one to change it. |
Right, enough is enough: I've waited too long for a decision on whether this and several other simple fixes can be landed, and it's not like we can tell whether any given contribution is Signed-off-by someone's legal name or a plausible pseudonym anyway, so I'm going to say the answer is "yes" and start merging pseudonymous contributions. @alexlarsson, @cgwalters, if this is a problem, please revert the relevant changes (and then get equivalent fixes some other way). |
(Except not right now, because unrelatedly the Github Actions configuration has regressed, so if anyone has objections to this, you have until the Actions are fixed to raise your objection.) |
eg. busybox stat only has -c and not --format Signed-off-by: Sertonix <[email protected]> Signed-off-by: Simon McVittie <[email protected]>
|
It looks like the most canonical docs for this are https://github.com/cncf/foundation/blob/main/dco-guidelines.md I believe the signoff line here qualifies. |
Thank you! |
eg. busybox stat only has -c and not --format