features: Support mountExtensions #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR upstream added the spec for the mountExtensions feature field: opencontainers/runtime-spec#1219 This commit just implements that and updates the OCI max version implemented to the one currently used in the spec (an unreleased version). It is not clear if in the future, the version of unreleased specs will be changed to something else: opencontainers/runtime-spec#1221 But this is what is currently accepted. Signed-off-by: Rodrigo Campos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upstream added the spec for the mountExtensions feature field:
opencontainers/runtime-spec#1219
This commit just implements that and updates the OCI max version implemented to the one currently used in the spec (an unreleased version).
It is not clear if in the future, the version of unreleased specs will be changed to something else:
opencontainers/runtime-spec#1221
But this is what is currently accepted.
Besides the tests here, I've also verified this against containerd integration tests.
cc @giuseppe