build: don't compile tests during normal build #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add a |
|
the change LGTM (assuming the CI passes :-) ) |
Signed-off-by: Jan Palus <[email protected]>
jpalus
force-pushed
the
no-tests-normal-build
branch
from
b8eff91 to
3c5292b
Compare
giuseppe
reviewed
Dec 9, 2024
Signed-off-by: Jan Palus <[email protected]>
jpalus
force-pushed
the
no-tests-normal-build
branch
from
d94bb21 to
9e3615a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the PR to get a feedback as it might have some side effects.
I think not compiling tests during normal build is the expected behavior however it shifts compilation to first
make checkinvocation which I believe in CI is done with escalated privileges. Might have some unexpected impact if some files have different ownership/permissions.