TMT: Replace adjust with prepare conditionals #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsm5
force-pushed
the
tmt-centos-stream-followup
branch
from
5367cf6 to
184f7a2
Compare
lsm5
force-pushed
the
tmt-centos-stream-followup
branch
11 times, most recently
from
34b6e2c to
575d5b5
Compare
|
podman system tests failed. @containers/packit-build please check. |
lsm5
force-pushed
the
tmt-centos-stream-followup
branch
5 times, most recently
from
e5a5058 to
7a09663
Compare
|
The latest patch seems to work though the commented out idiomatic TMT seems to fail. I'll check if there's any quick resolution from TMT folks, if not, we should just go ahead with this. |
Ensure all envs are setup correctly. Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
tmt-centos-stream-followup
branch
from
41b1261 to
65484cb
Compare
lsm5
changed the title
|
With this setup, packages from podman-next copr are fetched as expected on packit jobs and only the official packages are fetched on official distro PRs: https://gitlab.com/redhat/centos-stream/rpms/crun/-/merge_requests/120 and https://src.fedoraproject.org/rpms/crun/pull-request/92 . So, this should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
adjustconditionals ended up skipping copr repo and package upgrade steps for CentOS Stream environments.This should be resolved by directly using
prepareandwhenkeywords for setting conditions.