status: validate container id #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
force-pushed
the
status-validate-container-id
branch
3 times, most recently
from
cc8ca92 to
564dd37
Compare
|
You may want to have a quick look at the OpenScanHub report, although all of them may be false positives. |
thanks for the ping, yes they indeed look like false positives. Scanners are not very good at dealing with the |
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
check that the container name does not contain any slash so that operations in status.c won't risk to access directories/files outside of the run directory. Beside, it is not a security issue because if a directory exists, crun refuses to use it; and if it does not exist then it is created and immediately deleted because the container creation fails. Play safe and do not allow any slash in the container name. Closes: containers#1646 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
status-validate-container-id
branch
from
564dd37 to
432a66d
Compare
|
@flouthoc PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check that the container name does not contain any slash so that operations in status.c won't risk to access directories/files outside of the run directory.
Beside, it is not a security issue because if a directory exists, crun refuses to use it; and if it does not exist then it is created and immediately deleted because the container creation fails.
Play safe and do not allow any slash in the container name.
Closes: #1646