Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote: pod top -eo invalid: unmarshalling error #22986

Closed
edsantiago opened this issue Jun 12, 2024 · 0 comments · Fixed by #23080
Closed

remote: pod top -eo invalid: unmarshalling error #22986

edsantiago opened this issue Jun 12, 2024 · 0 comments · Fixed by #23080
Assignees
@Luap99
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@edsantiago
Copy link
Member 

$ bin/podman-remote run -d --pod new:foo quay.io/libpod/testimage:20240123 top 
b829985a6ffa9e8aa35114e48e44e1814469ddf8a801bc77bc3141d7c1065e47

$ bin/podman-remote pod top foo -eo bar
Error: unmarshalling into &handlers.PodTopOKBody{ContainerTopOKBody:container.ContainerTopOKBody{Processes:[][]string(nil), Titles:[]string(nil)}}, data "": unexpected end of JSON input
@edsantiago edsantiago added kind/bug Categorizes issue or PR as related to a bug. remote Problem is in podman-remote labels Jun 12, 2024
@edsantiago edsantiago mentioned this issue Jun 12, 2024
Merged
@Luap99 Luap99 self-assigned this Jun 24, 2024
@Luap99 Luap99 added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Jun 24, 2024
Luap99 added a commit to Luap99/libpod that referenced this issue Jun 24, 2024
@Luap99
remote API: fix pod top error reporting
e404976 
Do not return 200 status code before we know if there will be an error.
Delay writing the status code until we send the first response. That way
we can set an error code inside the loop when we get a error on the
first try, i.e. because an invalid descriptor was used.

Fixes containers#22986

Signed-off-by: Paul Holzinger <[email protected]>
@Luap99 Luap99 mentioned this issue Jun 24, 2024
Merged
mheon pushed a commit to mheon/libpod that referenced this issue Jul 10, 2024
@Luap99 @mheon
remote API: fix pod top error reporting
e251850 
Do not return 200 status code before we know if there will be an error.
Delay writing the status code until we send the first response. That way
we can set an error code inside the loop when we get a error on the
first try, i.e. because an invalid descriptor was used.

Fixes containers#22986

Signed-off-by: Paul Holzinger <[email protected]>

<MH: Fixed conflict in tests>

Signed-off-by: Matt Heon <[email protected]>
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Luap99 Luap99

Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libpod API: fix two pod remote error messages Luap99/libpod
2 participants
@edsantiago @Luap99