Makefile: simplify for modern Go

[kolyshkin]

This removes about 100 lines from the top-level Makefile.

Please review commit by commit, and see commit messages for details.

Note some of these changes are standing on the assumption that Go >= 1.16 is used (which is true since we use things like filepath.WalkDir which require go 1.16).

[lsm5]

/approve

[mheon]

Test failures seem related

[lsm5]

@kolyshkin RE: podman.spec.rpkg we'll need to ensure that rpkg local or make package works. Your current PR gives me this:

$ rpkg local
ERROR: git_dir_version: Could not get remote URL.
git_dir_version failed with value 1.

[lsm5]

@kolyshkin RE: podman.spec.rpkg we'll need to ensure that rpkg local or make package works. Your current PR gives me this:

$ rpkg local
ERROR: git_dir_version: Could not get remote URL.
git_dir_version failed with value 1.

I wonder if it's related to your fork being called libpod.

[kolyshkin]

OK, this should work now. The problem with rpm building was caused by the fact that gobuild macro is setting GO111MODULE=off which makes it unable to build using relative vendor subdirectory. Fixed by having

%global gomodulesmode GO111MODULE=on

[edsantiago]

LGTM in principle, but I don't know enough Go to approve. It's not passing CI, though.

[kolyshkin]

The error from "Test Code Consistency" job

go: downloading github.com/uber/jaeger-client-go v2.30.0+incompatible
go: github.com/containers/[email protected] requires
	github.com/containerd/[email protected] requires
	github.com/containerd/[email protected] requires
	github.com/containerd/[email protected] requires
	github.com/Microsoft/[email protected] requires
	github.com/containerd/[email protected] requires
	github.com/Microsoft/hcsshim/[email protected] requires
	github.com/docker/[email protected] requires
	google.golang.org/[email protected]: invalid version: git fetch --unshallow -f origin in /var/tmp/go/pkg/mod/cache/vcs/14bb952cc8902e20fb82cb08a9d29b90b010f5d6d0d3737e9cb402b3b57a25b5: exit status 128:
	fatal: fetch-pack: invalid index-pack output
make: *** [Makefile:257: vendor] Error 1

seems like a network glitch. Perhaps we should remove "make vendor" from most of the jobs, since it is error prone and doing it once is enough.

[kolyshkin]

OK, for some reason Cirrus-CI has GOPROXY=direct set (and also GOSUMDB=off). I was not able to find out where this is being set, perhaps @saschagrunert knows something? This is definitely not the default setting so it must be set somewhere.

So I had to add the following to .cirrus.yml to combat that:

    # Sane (default) value for GOPROXY and GOSUMDB.
    GOPROXY: "https://proxy.golang.org,direct"
    GOSUMDB: "sum.golang.org"

[kolyshkin]

It's not passing CI, though.

I am still working on it, thus it's a draft.

[kolyshkin]

OK, this one is ready, PTAL @edsantiago @lsm5 @Luap99 @vrothberg

[vrothberg]

Thanks, @kolyshkin! Much appreciated.

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, lsm5, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lsm5,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm

[edsantiago]

@lsm5 can you, if it's not too hard, trigger a manual koji build? This is a big scary PR with lots of potential to break builds, and it would be nice to catch breakage early. (Clarification: good stuff, but still big and scary)

[lsm5]

@edsantiago sorry about the late response, the rhcontainerbot/podman-next copr has had successful builds recently, so all's well. https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/package/podman/ . I'll need to check if the fedora sources need further changes to make use of the changes in this PR.

Thanks @kolyshkin !!