Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExitWithError() - continued #22926

Merged

Conversation

edsantiago
Copy link
Member

Convert Exit(N) to ExitWithError(N, "expected error")

Signed-off-by: Ed Santiago [email protected]

None

Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
@rhatdan
Copy link
Member

rhatdan commented Jun 6, 2024

LGTM

test/e2e/cleanup_test.go Outdated Show resolved Hide resolved
Convert Exit(N) to ExitWithError(N, "expected error")

Signed-off-by: Ed Santiago <[email protected]>
@edsantiago edsantiago force-pushed the exitwitherror-continued branch from 7739dc5 to f317eb2 Compare June 6, 2024 18:00
@rhatdan
Copy link
Member

rhatdan commented Jun 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 37663cb into containers:main Jun 6, 2024
90 checks passed
@edsantiago edsantiago deleted the exitwitherror-continued branch June 7, 2024 01:54
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 6, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants