Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] podman 5, pasta and inter-container networking #22933

Merged
merged 1 commit into from
Jun 10, 2024
Merged

[CI:DOCS] podman 5, pasta and inter-container networking #22933

merged 1 commit into from
Jun 10, 2024

Conversation

marinmo
Copy link
Contributor

@marinmo marinmo commented Jun 7, 2024 •
edited by Luap99
Loading

add information about pasta and how its behaviour changes the way a user needs to think about inter-container connections, as without configuration they aren't able to reach each other (assuming single interface)

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Jun 7, 2024
@marinmo
Copy link
Contributor Author

marinmo commented Jun 7, 2024

Should probably have added that this is a PR regarding documentation. Ah well, better late than never!

@Luap99 Luap99 changed the title podman 5, pasta and inter-container networking [CI:DOCS] podman 5, pasta and inter-container networking Jun 7, 2024
Luap99
Luap99 reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good, one small nit

rootless.md Outdated Show resolved Hide resolved
@marinmo
Copy link
Contributor Author

marinmo commented Jun 7, 2024

Thanks looks good, one small nit

Thanks! Adjusted

@Luap99
Copy link
Member

Luap99 commented Jun 7, 2024

Thanks can you squash the commits please.

@openshift-ci openshift-ci bot added release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Jun 7, 2024
@marinmo
Copy link
Contributor Author

marinmo commented Jun 7, 2024

That should do it I think? First time I squashed commits but looks alright now as far as I can tell ... :)

@TomSweeneyRedHat
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2024
TomSweeneyRedHat
TomSweeneyRedHat reviewed Jun 7, 2024
View reviewed changes
rootless.md Outdated Show resolved Hide resolved
TomSweeneyRedHat
TomSweeneyRedHat reviewed Jun 7, 2024
View reviewed changes
rootless.md Outdated Show resolved Hide resolved
@TomSweeneyRedHat
Copy link
Member

I got my Grammar Hammer out and found a few things to squish. But overall, it looks great. Thanks!

@marinmo @TomSweeneyRedHat
podman 5, pasta and inter-container networking
cec6859 
add information about pasta and how its behaviour changes the way a user needs to think about inter-container connections, as without configuration they aren't able to reach each other (assuming single interface)

Signed-off-by: marinmo <[email protected]>

Update rootless.md

Co-authored-by: Paul Holzinger <[email protected]>
Signed-off-by: marinmo <[email protected]>

Update rootless.md

Co-authored-by: Tom Sweeney <[email protected]>
Signed-off-by: marinmo <[email protected]>

Update rootless.md

Co-authored-by: Tom Sweeney <[email protected]>
Signed-off-by: marinmo <[email protected]>
@marinmo
Copy link
Contributor Author

marinmo commented Jun 7, 2024

I got my Grammar Hammer out and found a few things to squish. But overall, it looks great. Thanks!

All changes merged and squashed, thanks!

ashley-cui
ashley-cui approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui, marinmo, TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [TomSweeneyRedHat,ashley-cui]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2f5ce5d into containers:main Jun 10, 2024
40 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 9, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@ashley-cui ashley-cui ashley-cui approved these changes

Assignees

@ashley-cui ashley-cui

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marinmo @Luap99 @TomSweeneyRedHat @ashley-cui