-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding packit kvm-test temporary-fix #716
Conversation
Reviewer's Guide by SourceryThe pull request temporarily modifies the packit configuration to use Fedora 41 instead of Fedora Latest for the kvm-tier-0 test job. This is due to Fedora 42 not being available in public-tf. Flow diagram of updated KVM test configurationflowchart LR
subgraph Before
FL[fedora-latest]
E9[epel-9-x86_64]
end
subgraph After
F41[fedora-41]
E9_2[epel-9-x86_64]
end
Before --> After
note[Note: Temporary fix until Fedora 42<br>is published to public-tf]
style note fill:#ffeeee,stroke:#ff0000
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Yarboa - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider updating the PR description to include clearer context on why fedora-41 is used as a temporary fix, and fix the typos (e.g., 'Chenged' and 'frpm') to improve clarity.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Due to this https://github.com/containers/qm/pull/710/checks?check_run_id=36772216370 Chenged packit kvm test frpm fedora-latest -> fedora-41 Signed-off-by: Yariv Rachmani <[email protected]>
003bb54
to
071586d
Compare
Due to this
https://github.com/containers/qm/pull/710/checks?check_run_id=36772216370
Changed packit kvm test from fedora-latest -> fedora-41
All explained at above url
fix this gate error #710