Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding packit kvm-test temporary-fix #716

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

Yarboa
Copy link
Collaborator

@Yarboa Yarboa commented Feb 6, 2025

Due to this
https://github.com/containers/qm/pull/710/checks?check_run_id=36772216370

Changed packit kvm test from fedora-latest -> fedora-41
All explained at above url
fix this gate error #710

Copy link

sourcery-ai bot commented Feb 6, 2025

Reviewer's Guide by Sourcery

The pull request temporarily modifies the packit configuration to use Fedora 41 instead of Fedora Latest for the kvm-tier-0 test job. This is due to Fedora 42 not being available in public-tf.

Flow diagram of updated KVM test configuration

flowchart LR
    subgraph Before
        FL[fedora-latest]
        E9[epel-9-x86_64]
    end
    subgraph After
        F41[fedora-41]
        E9_2[epel-9-x86_64]
    end
    Before --> After
    note[Note: Temporary fix until Fedora 42<br>is published to public-tf]
    style note fill:#ffeeee,stroke:#ff0000
Loading

File-Level Changes

Change Details Files
Temporarily switch from fedora-latest to fedora-41 for kvm-tier-0 test job.
  • Commented out fedora-latest.
  • Added fedora-41.
  • Added a comment explaining the change.
.packit.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Yarboa - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider updating the PR description to include clearer context on why fedora-41 is used as a temporary fix, and fix the typos (e.g., 'Chenged' and 'frpm') to improve clarity.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Due to this
https://github.com/containers/qm/pull/710/checks?check_run_id=36772216370
Chenged packit kvm test frpm fedora-latest -> fedora-41

Signed-off-by: Yariv Rachmani <[email protected]>
@Yarboa Yarboa force-pushed the public-tf-compose branch from 003bb54 to 071586d Compare February 6, 2025 09:35
@Yarboa Yarboa merged commit e67a909 into containers:main Feb 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant