Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gotify): include redirects when tls is disabled #154

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Mar 30, 2021

if DisableTLS is specified, disable TLS verification as well since the default configuration of Gotify redirects HTTP to HTTPS, rendering the schema change moot

if DisableTLS is specified, disable TLS verification as well
since the default configuration of Gotify redirects HTTP to
HTTPS, rendering the schema change moot
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #154 (f0695b5) into main (469140f) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   63.98%   64.10%   +0.12%     
==========================================
  Files          70       70              
  Lines        1999     2006       +7     
==========================================
+ Hits         1279     1286       +7     
  Misses        606      606              
  Partials      114      114              
Impacted Files Coverage Δ
pkg/services/gotify/gotify.go 76.92% <100.00%> (+3.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab9f634...f0695b5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant