Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute path for entrypoint in Dockerfile #169

Merged
merged 1 commit into from
May 31, 2021

Conversation

arnested
Copy link
Member

@arnested arnested commented May 30, 2021

If the entrypoint uses a relative path we are not able to set a different working directory, i.e. in Dockerfiles extending this.

If the entrypoint uses a relative path we are not able to set a
different working directory, i.e. in Dockerfiles extending this.
@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #169 (edb32ef) into main (e156cfd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   63.08%   63.08%           
=======================================
  Files          79       79           
  Lines        2487     2487           
=======================================
  Hits         1569     1569           
  Misses        780      780           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e156cfd...edb32ef. Read the comment docs.

Copy link
Member

@piksel piksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it was intentional anyway.

@piksel piksel merged commit d8371b8 into containrrr:main May 31, 2021
@arnested arnested deleted the dockerfile-entrypoint branch May 31, 2021 21:21
arnested added a commit to containrrr/shoutrrr-action that referenced this pull request Aug 16, 2021
No longer needed. It has been fixed upstream:
containrrr/shoutrrr#169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants