Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: discord avatar override #172

Merged
merged 1 commit into from
Jul 1, 2021
Merged

fix: discord avatar override #172

merged 1 commit into from
Jul 1, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Jun 1, 2021

Fixes Discord avatar override not being populated in the webhook payload. Also, this fixes the documentation name of the prop (and adds an alias for avatarurl which was listed in the docs previosuly).

@piksel piksel linked an issue Jun 1, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #172 (6bf798b) into main (d8371b8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   63.08%   63.10%   +0.01%     
==========================================
  Files          79       79              
  Lines        2487     2488       +1     
==========================================
+ Hits         1569     1570       +1     
  Misses        780      780              
  Partials      138      138              
Impacted Files Coverage Δ
pkg/services/discord/discord_config.go 82.35% <ø> (ø)
pkg/services/discord/discord_json.go 91.66% <ø> (ø)
pkg/services/discord/discord.go 56.52% <100.00%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8371b8...6bf798b. Read the comment docs.

@piksel piksel merged commit 17f842b into main Jul 1, 2021
@piksel piksel deleted the fix/discord-avatar branch July 1, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discord custom avatar not working
1 participant