Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): avoid mutating passed params #184

Merged
merged 1 commit into from
Jul 18, 2021
Merged

fix(logger): avoid mutating passed params #184

merged 1 commit into from
Jul 18, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Jul 18, 2021

this fixes an old bug where the logger, when combined with other services would add the param message to other services Send() (which they usually don't like).

also added tests for this and for normal operation.

@codecov
Copy link

codecov bot commented Jul 18, 2021

Codecov Report

Merging #184 (91e332b) into main (8018a47) will increase coverage by 0.07%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   63.58%   63.65%   +0.07%     
==========================================
  Files          84       86       +2     
  Lines        2694     2713      +19     
==========================================
+ Hits         1713     1727      +14     
- Misses        832      836       +4     
- Partials      149      150       +1     
Impacted Files Coverage Δ
pkg/services/logger/logger.go 87.50% <85.71%> (ø)
pkg/services/logger/logger_config.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8018a47...91e332b. Read the comment docs.

@piksel piksel merged commit 5d12d75 into main Jul 18, 2021
@piksel piksel deleted the fix/logger-params branch July 18, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant