Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smtp): remove extra semi in mime header #201

Merged
merged 1 commit into from
Sep 4, 2021
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Sep 4, 2021

The MIME-Version header sent by the smtp service contained a trailing ; which seems to sometimes cause SpamAssassin to trigger the BOGUS_MIME_VERSION rule. Upon testing, this happened roughly 1/5 of the time, using the exact same message.

When removing the trailing ;, I have not been able to trigger the rule.

fixes #200

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #201 (6dd5bdd) into main (441d5cf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   76.87%   76.87%           
=======================================
  Files          85       85           
  Lines        2703     2703           
=======================================
  Hits         2078     2078           
  Misses        442      442           
  Partials      183      183           
Impacted Files Coverage Δ
pkg/services/smtp/smtp.go 82.01% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 441d5cf...6dd5bdd. Read the comment docs.

@piksel piksel added Type: Bug Something isn't working Service: SMTP Related to the SMTP service labels Sep 4, 2021
@piksel piksel merged commit b1a59a7 into main Sep 4, 2021
@piksel piksel deleted the fix/smtp-mime-version branch September 4, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Service: SMTP Related to the SMTP service Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emails flagged as spam
1 participant