-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CLI command to /shoutrrr #220
Conversation
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
=======================================
Coverage 76.95% 76.95%
=======================================
Files 85 85
Lines 2703 2703
=======================================
Hits 2080 2080
Misses 441 441
Partials 182 182 Continue to review full report at Codecov.
|
I would probably prefer it to be shoutrrr/shoutrrr instead. I feel like the extra "cmd" doesn't serve any purpose and is less often used as a pattern for CLIs (in my experience). |
It is a common convention for go applications, however. |
I would also say it's quite common. A few examples:
|
Yeah, but those either have multiple binaries (or plan to?), and then it makes sense, but for a single-binary project like this (which instead uses sub-commands), I prefer the style of:
|
You battle it out 😂 I'm down with whichever, although I have a slight preference for the |
I'll change it. The most important part for me was just being able to |
Change pushed. I'll squash the two commits before this is final and ready to merge. Putting the command in the folder named |
Haha, sorry for being unreasonable :D I don't care that much either. I'm just selfishly plotting to reduce the huge amount of characters I have to type :D |
bea80b4
to
7fe1458
Compare
This will make the CLI command installable by running: ``` go install github.com/containrrr/shoutrrr/shoutrrr@latest ``` When installing using `go install` previously the command got installed with the binary name `cli`.
I have squashed the commits, and it's ready for merge. |
This will make the CLI command installable by running:
When installing using
go install
previously the command got installedwith the binary name
cli
.