-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(telegram): update docs and generator for private channels #250
Conversation
Codecov Report
@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 77.73% 77.85% +0.11%
==========================================
Files 96 96
Lines 2866 2877 +11
==========================================
+ Hits 2228 2240 +12
+ Misses 468 466 -2
- Partials 170 171 +1
Continue to review full report at Codecov.
|
I'd still recommend the forward message to 'JSON Dump Bot' method to get the chat ID. Doesn't require a PC/Docker compared to |
@JosephKav Yeah, good point. My main concern is that it's a third party bot that is out of our control regarding what it's actually doing. Shoutrrr CLI works fine outside of docker and even runs on android. The only reason for recommending the docker way is that it's a single line to download, run and remove the CLI in one go (and it's always updated). |
fda0238
to
d5ea223
Compare
@JosephKav I added another section, but replaced |
Since neither |
The current docs regarding telegram channel names only applies to public channels. Addressing private channels is not possible using the described
@channelname
syntax.This PR fixes the documentation regarding this, and makes the telegram generator display private channels correctly (instead of just calling them
@
).Fixes #249