-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and improve GitHub Actions #273
Conversation
Codecov ReportBase: 78.49% // Head: 78.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
+ Coverage 78.49% 78.54% +0.05%
==========================================
Files 96 96
Lines 2934 4275 +1341
==========================================
+ Hits 2303 3358 +1055
- Misses 462 746 +284
- Partials 169 171 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Looks great! Thanks. |
In next I actually use Go v1.18, but it can probably be made to work with an earlier version with some ungeneralization. |
I don't know if this is the cause, but it seems like PRs sometimes do not trigger the main action anymore... |
I wouldn't have thought so. But I'll have a look in about an hour. What pr did you notice it on? |
In #283 it didn't trigger, but I first saw it somewhere else. It might've just be a github issue though, it seems fine now. |
1 similar comment
In #283 it didn't trigger, but I first saw it somewhere else. It might've just be a github issue though, it seems fine now. |
Weird... I can't see why. I'll try to create a new PR with some minor documentation cleanup just to see what happens. |
#284 worked as intended. Maybe a GitHub slowdown. |
Use build matrix of go versions
GitHub Actions only tested the build using go 1.13 (which has been unsupported by the Go team for more than two years).
Introduce a build matrix testing all versions from the lowest supported by shoutrrr to the newest released by the Go team (shamelessly using my own Go Version Action).
Bump required go to 1.13 in
go.mod
The matrix test showed the code didn't compile in go1.12 anymore.
Build release using latest Go version
The release action built the version for release with go 1.13. From now, we'll use the latest go release.
Bump codecov action version
The old version used node 12 which is deprecated by GitHub Actions
Use goreleaser action
Instead of installing goreleaser by ourselves, we'll let the goreleaser action install it.
Add @dependabot configuration
Let @dependabot create pull requests for new dependencies in
go.mod
,Dockerfile
, and GitHub Actions. This should make it easier to stay up-to-date.Add GitHub Action permissions
GitHub has introduced permissions for GitHub Actions to increase the safety of the actions.