Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and improve GitHub Actions #273

Merged
merged 7 commits into from
Oct 18, 2022
Merged

Conversation

arnested
Copy link
Member

Use build matrix of go versions

GitHub Actions only tested the build using go 1.13 (which has been unsupported by the Go team for more than two years).

Introduce a build matrix testing all versions from the lowest supported by shoutrrr to the newest released by the Go team (shamelessly using my own Go Version Action).

Bump required go to 1.13 in go.mod

The matrix test showed the code didn't compile in go1.12 anymore.

Build release using latest Go version

The release action built the version for release with go 1.13. From now, we'll use the latest go release.

Bump codecov action version

The old version used node 12 which is deprecated by GitHub Actions

Use goreleaser action

Instead of installing goreleaser by ourselves, we'll let the goreleaser action install it.

Add @dependabot configuration

Let @dependabot create pull requests for new dependencies in go.mod, Dockerfile, and GitHub Actions. This should make it easier to stay up-to-date.

Add GitHub Action permissions

GitHub has introduced permissions for GitHub Actions to increase the safety of the actions.

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 78.49% // Head: 78.54% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (62f632b) compared to base (4a5ee05).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   78.49%   78.54%   +0.05%     
==========================================
  Files          96       96              
  Lines        2934     4275    +1341     
==========================================
+ Hits         2303     3358    +1055     
- Misses        462      746     +284     
- Partials      169      171       +2     
Impacted Files Coverage Δ
pkg/services/smtp/smtp_encmethod.go 80.00% <0.00%> (-7.50%) ⬇️
pkg/services/rocketchat/rocketchat_config.go 64.86% <0.00%> (-4.37%) ⬇️
pkg/services/opsgenie/opsgenie_entity.go 67.56% <0.00%> (-3.87%) ⬇️
pkg/services/pushover/pushover_config.go 87.09% <0.00%> (-2.91%) ⬇️
pkg/services/teams/teams.go 71.23% <0.00%> (-2.77%) ⬇️
pkg/services/discord/discord.go 79.01% <0.00%> (-1.69%) ⬇️
pkg/services/generic/generic.go 85.00% <0.00%> (-1.67%) ⬇️
pkg/services/opsgenie/opsgenie.go 64.47% <0.00%> (-1.63%) ⬇️
pkg/services/telegram/telegram_json.go 92.85% <0.00%> (-1.59%) ⬇️
pkg/services/pushover/pushover.go 72.72% <0.00%> (-1.47%) ⬇️
... and 85 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@piksel
Copy link
Member

piksel commented Oct 18, 2022

Looks great! Thanks.

@piksel
Copy link
Member

piksel commented Oct 18, 2022

In next I actually use Go v1.18, but it can probably be made to work with an earlier version with some ungeneralization.

@piksel piksel merged commit 0ce2430 into containrrr:main Oct 18, 2022
piksel pushed a commit that referenced this pull request Oct 18, 2022
@piksel
Copy link
Member

piksel commented Oct 18, 2022

I don't know if this is the cause, but it seems like PRs sometimes do not trigger the main action anymore...

@arnested
Copy link
Member Author

I wouldn't have thought so. But I'll have a look in about an hour.

What pr did you notice it on?

@piksel
Copy link
Member

piksel commented Oct 18, 2022

In #283 it didn't trigger, but I first saw it somewhere else. It might've just be a github issue though, it seems fine now.

1 similar comment
@piksel
Copy link
Member

piksel commented Oct 18, 2022

In #283 it didn't trigger, but I first saw it somewhere else. It might've just be a github issue though, it seems fine now.

@arnested arnested deleted the actions branch October 18, 2022 09:59
@arnested
Copy link
Member Author

Weird... I can't see why. I'll try to create a new PR with some minor documentation cleanup just to see what happens.

@arnested
Copy link
Member Author

Weird... I can't see why. I'll try to create a new PR with some minor documentation cleanup just to see what happens.

#284 worked as intended. Maybe a GitHub slowdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants