Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the cli available as a snap #304

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Make the cli available as a snap #304

merged 3 commits into from
Dec 14, 2022

Conversation

simskij
Copy link
Member

@simskij simskij commented Dec 10, 2022

Given how good and easy the CLI has become to use, it only makes sense for it to also be available as a snap on the snapstore. I've gone ahead and registered the snap name already and published a revision on the stable track.

This PR moves the ownership of the snap packing spec to the containrrr team.

Snapstore Entry

@simskij simskij requested review from arnested and piksel December 10, 2022 11:40
@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Base: 78.75% // Head: 78.75% // No change to project coverage 👍

Coverage data is based on head (cc48b8e) compared to base (d326917).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   78.75%   78.75%           
=======================================
  Files          97       97           
  Lines        4279     4279           
=======================================
  Hits         3370     3370           
  Misses        738      738           
  Partials      171      171           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simskij
Copy link
Member Author

simskij commented Dec 10, 2022

In the scope of this PR, Im taking zero responsibility for the codacy check failing. 😅 EDIT: Ok I do, and the dollar sign warning for markdown shell codeblocks has now been disabled.

@simskij simskij merged commit 32d969c into main Dec 14, 2022
@simskij simskij deleted the feature/snap branch December 14, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant