feat(smtp): add support for oauth2 and gmail generators #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simskij
force-pushed
the
master
branch
10 times, most recently
from
c2d0dfb to
b25afa1
Compare
piksel
force-pushed
the
feature/smtp-xoauth2
branch
from
6deb6dc to
89fc243
Compare
# Conflicts: # pkg/generators/router.go
|
I don't think there is much more to add here. This supports XOAUTH2 authentication for the consumers that want it. More built in providers could be added, but it's not something I am doing anytime soon (unless there is a explicit need for it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator entry points are temporary until #32 is done.
A better API for service generators should be probably be added.