test: add unit test for implicit restart

containrrr · Oct 24, 2021 · f921a70 · f921a70
1 parent eb831df
commit f921a70
Show file tree

Hide file tree

Showing 3 changed files with 54 additions and 5 deletions.
diff --git a/internal/actions/update.go b/internal/actions/update.go
@@ -69,7 +69,7 @@ func Update(client container.Client, params types.UpdateParams) (types.Report, e
 		return nil, err
 	}
 
-	updateImplicitRestart(containers)
+	UpdateImplicitRestart(containers)
 
 	var containersToUpdate []container.Container
 	if !params.MonitorOnly {
@@ -217,9 +217,9 @@ func restartStaleContainer(container container.Container, client container.Clien
 	return nil
 }
 
-// updateImplicitRestart iterates through the passed containers, setting the
+// UpdateImplicitRestart iterates through the passed containers, setting the
 // `LinkedToRestarting` flag if any of it's linked containers are marked for restart
-func updateImplicitRestart(containers []container.Container) {
+func UpdateImplicitRestart(containers []container.Container) {
 
 	for ci, c := range containers {
 		if c.ToRestart() {

diff --git a/internal/actions/update_test.go b/internal/actions/update_test.go
@@ -30,6 +30,7 @@ var _ = Describe("the update action", func() {
 		BeforeEach(func() {
 			pullImages := false
 			removeVolumes := false
+			//goland:noinspection GoBoolExpressions
 			client = CreateMockClient(
 				&TestData{
 					NameOfContainerToKeep: "test-container-02",
@@ -271,6 +272,54 @@ var _ = Describe("the update action", func() {
 			})
 		})
 
+		When("container is linked to restarting containers", func() {
+			It("should be marked for restart", func() {
+
+				provider := CreateMockContainerWithConfig(
+					"test-container-provider",
+					"/test-container-provider",
+					"fake-image2:latest",
+					true,
+					false,
+					time.Now(),
+					&dockerContainer.Config{
+						Labels:       map[string]string{},
+						ExposedPorts: map[nat.Port]struct{}{},
+					})
+
+				provider.Stale = true
+
+				consumer := CreateMockContainerWithConfig(
+					"test-container-consumer",
+					"/test-container-consumer",
+					"fake-image3:latest",
+					true,
+					false,
+					time.Now(),
+					&dockerContainer.Config{
+						Labels: map[string]string{
+							"com.centurylinklabs.watchtower.depends-on": "test-container-provider",
+						},
+						ExposedPorts: map[nat.Port]struct{}{},
+					})
+
+				containers := []container.Container{
+					provider,
+					consumer,
+				}
+
+				Expect(provider.ToRestart()).To(BeTrue())
+				Expect(consumer.ToRestart()).To(BeFalse())
+
+				actions.UpdateImplicitRestart(containers)
+
+				Expect(containers[0].ToRestart()).To(BeTrue())
+				Expect(containers[1].ToRestart()).To(BeTrue())
+
+			})
+
+		})
+
 		When("container is not running", func() {
 			BeforeEach(func() {
 				client = CreateMockClient(

diff --git a/scripts/dependency-test.sh b/scripts/dependency-test.sh
@@ -4,8 +4,8 @@
 # Note that this test does not verify the results in any way
 
 set -e
-SCRIPT_ROOT=$(dirname $(readlink -m $( type -p ${0} )))
-source $SCRIPT_ROOT/docker-util.sh
+SCRIPT_ROOT=$(dirname "$(readlink -m "$(type -p "$0")")")
+source "$SCRIPT_ROOT/docker-util.sh"
 
 DepArgs=""
 if [ -z "$1" ] || [ "$1" == "depends-on" ]; then