Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump alpine version in dockerfile #1151

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

naioja
Copy link
Contributor

@naioja naioja commented Dec 4, 2021

Using a newer supported alpine version that still provides security fixes.

@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #1151 (a9679e1) into main (d2f1185) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1151   +/-   ##
=======================================
  Coverage   61.89%   61.89%           
=======================================
  Files          23       23           
  Lines        1475     1475           
=======================================
  Hits          913      913           
  Misses        476      476           
  Partials       86       86           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f1185...a9679e1. Read the comment docs.

@simskij
Copy link
Member

simskij commented Dec 7, 2021

Not sure whether this is relevant given that we only use alpine to fetch the certs and the timezone. Wouldn't hurt though, so I guess why not 😅

@naioja
Copy link
Contributor Author

naioja commented Dec 7, 2021

Not sure whether this is relevant given that we only use alpine to fetch the certs and the timezone. Wouldn't hurt though, so I guess why not 😅

Running trivy on the old image was a bit unsettling :)

@piksel piksel changed the title Using a newer supported alpine version that still provides security fixes. chore: bump alpine version in dockerfile Dec 20, 2021
@piksel piksel merged commit 6ff1d8a into containrrr:main Dec 20, 2021
@naioja naioja deleted the bump_alpine_version branch December 20, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants