Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag to disable to the memory swappiness #2072

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soyji
Copy link

@soyji soyji commented Jan 23, 2025

Hi, this is jiahaojz-onum smurf account, this issue closes #1060

I am running podman with crun and cgroupv2, default in systems like redhat

β”ŒπŸ’  jiahao-ji-zhou @ πŸ’»  jiahao-ji-zhou-ThinkPad-E14-Gen-5 in πŸ“  watchtower on 🌿  feat/podman-compatibility β†’ origin βŒ€3 βœ—
└❯ podman info | grep -i runtime -A3
  ociRuntime:
    name: crun
    package: crun_1.14.1-1_amd64
    path: /usr/bin/crun

β”ŒπŸ’  jiahao-ji-zhou @ πŸ’»  jiahao-ji-zhou-ThinkPad-E14-Gen-5 in πŸ“  watchtower on 🌿  feat/podman-compatibility β†’ origin βŒ€3 βœ—
└❯ podman info | grep cgroupVersion
  cgroupVersion: v2

The tests performed are for checking that watchtower works with podman. Those are executions with the flag:

image

image

Then the tests performed without the flag (the normal behaviour):

image

image

@soyji soyji requested a review from simskij as a code owner January 23, 2025 11:15
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on opening your first pull request! We'll get back to you as soon as possible. In the meantime, please make sure you've updated the documentation to reflect your changes and have added test automation as needed. Thanks! πŸ™πŸΌ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support for Podman
1 participant