-
Notifications
You must be signed in to change notification settings - Fork 76
Add the "folder structure" chapter and modify the "extension" chapter #370
Conversation
Wow, this is great! Two things:
|
Ok I will separate into two sub-chapter "with Composer" and "manually".
Can I have an example please? |
public function registerBundles()
{
$bundles = [
new Symfony\Bundle\FrameworkBundle\FrameworkBundle(),
new Contao\CoreBundle\ContaoCoreBundle(),
new Contao\CoreBundle\HttpKernel\Bundle\ContaoModuleBundle('myExtensionName', $this->getRootDir()),
];
return $bundles;
} |
Thanks! |
I added this part in 7bc9f0f. |
@aschempp Could you add a new branch for the 4.2 please |
|
||
An extension that can be installed via Composer can be found through its main | ||
repository [Packagist][2]. A name of an extension is divided into two parts. | ||
The first part is the name of the project owner and the second the extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
project owner is usually called vendor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept "project owner" in parentheses because everyone does not necessarily know this term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like me for example ;-)
@aschempp I made all the changes. |
Not sure if that's correct. @leofeyer do we call |
The part about installing extensions is a bit confusing to me. It explains about bundles, but what we're installing in the example seems to be old Contao 3 extensions. Are you intentionally not mentioning how to install a real bundle? Maybe we should be more clear about the differences? |
No it's not intentional. I will improve this point... Add the installation of a real bundle and make the difference between the two types of extension. |
Just |
@aschempp it's better now WDYT? |
Great progress! For a Contao 3 extension to be installed in Contao 4, a developer has to mark it as compatible. Therefore the warning about compatibility should probably go into the "manual installation" section, what do you think? We should also add a link to Packagist that lists all Contao things, they currently look like this: |
…out this topic in the installation part.
I removed the warning and improved the existing chapter (Contao modules) on this subject in c066a7c. |
I added a new sub-chapter (Finding extensions or bundles). |
What do you think about changing the chapter name: "Extensions and bundles" instead of "Extensions" only? |
I like it 😎 |
Yes thx 👍 |
@aschempp I recreate this PR for the 4.2 branch with the last changes? UPDATE: https://github.com/blog/2224-change-the-base-branch-of-a-pull-request 👍 |
Reviewed this again. I wonder if the folder structure belongs to the chapter "installing Contao"? Not really relevant for a regular user, is it? Maybe we should move this to a cookbook chapter, what do you think? |
OK I will create a chapter with this part in the cookbook and recreating this PR that will target the 4.2 branch. |
This is the same as #345 but without adding a new chapter.