Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SDK for CAWG identity assertion #644

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Conversation

scouten-adobe
Copy link
Collaborator

@scouten-adobe scouten-adobe self-assigned this Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 81.01415% with 161 lines in your changes missing coverage. Please review.

Project coverage is 80.19%. Comparing base (b12fffd) to head (43c7e52).

Files with missing lines Patch % Lines
cawg_identity/src/claim_aggregation/w3c_vc/did.rs 68.26% 33 Missing ⚠️
cawg_identity/src/claim_aggregation/w3c_vc/jwk.rs 73.14% 29 Missing ⚠️
cawg_identity/src/identity_assertion/mod.rs 84.78% 21 Missing ⚠️
...tity/src/claim_aggregation/w3c_vc/serialization.rs 50.00% 20 Missing ⚠️
...src/claim_aggregation/cose_vc_signature_handler.rs 84.40% 17 Missing ⚠️
..._identity/src/identity_assertion/signer_payload.rs 73.01% 17 Missing ⚠️
...laim_aggregation/identity_claims_aggregation_vc.rs 44.82% 16 Missing ⚠️
...g_identity/src/claim_aggregation/w3c_vc/did_web.rs 94.11% 4 Missing ⚠️
...g_identity/src/claim_aggregation/w3c_vc/did_doc.rs 50.00% 3 Missing ⚠️
cawg_identity/src/builder/manifest_builder.rs 98.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
+ Coverage   80.08%   80.19%   +0.10%     
==========================================
  Files         118      135      +17     
  Lines       31285    32129     +844     
==========================================
+ Hits        25056    25765     +709     
- Misses       6229     6364     +135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

scouten-adobe added a commit that referenced this pull request Jan 8, 2025
Includes `NaiveCredentialHolder` implementation to be used in test cases only.

Split off from #644.
scouten-adobe added a commit that referenced this pull request Jan 8, 2025
Includes `NaiveCredentialHolder` implementation to be used in test cases only.

Split off from #644.
scouten-adobe added a commit that referenced this pull request Jan 8, 2025
scouten-adobe added a commit that referenced this pull request Jan 8, 2025
Copy link
Contributor

@tmathern tmathern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp approval, as I'm probably not the best person to review all this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants