feat: Claim v2 #707
Open
feat: Claim v2 #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aim_v2 # Conflicts: # sdk/src/claim.rs
…aim_v2 # Conflicts: # sdk/src/cose_validator.rs # sdk/src/error.rs
…aim_v2 # Conflicts: # sdk/src/time_stamp.rs
…aim_v2 # Conflicts: # sdk/src/time_stamp.rs # sdk/src/wasm/webcrypto_validator.rs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #707 +/- ##
==========================================
+ Coverage 78.82% 79.03% +0.21%
==========================================
Files 141 143 +2
Lines 32171 33936 +1765
==========================================
+ Hits 25358 26821 +1463
- Misses 6813 7115 +302 ☔ View full report in Codecov by Sentry. |
scouten-adobe
added a commit
that referenced
this pull request
Dec 4, 2024
# Conflicts: # sdk/src/signer.rs # sdk/src/time_stamp.rs
Add validation_results method to reader. Add some ValidationResults docs
processes informational status (when we have them)
tmathern
reviewed
Jan 24, 2025
tmathern
reviewed
Jan 24, 2025
tmathern
approved these changes
Jan 24, 2025
crandmck
requested changes
Jan 24, 2025
| } | ||
| (box_name.into(), 0) | ||
| } | ||
|
|
||
| /// Return the label for this assertion given its link | ||
| pub fn assertion_label_from_link(assertion_link: &str) -> (String, usize) { |
There was a problem hiding this comment.
@scouten-adobe continue review from here (probably tomorrow)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Support V2 Claim processing
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.