-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add RawSigner
trait to c2pa-crypto
(derived from c2pa::Signer
)
#716
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
- Coverage 80.71% 80.59% -0.12%
==========================================
Files 117 117
Lines 31554 31540 -14
==========================================
- Hits 25468 25420 -48
- Misses 6086 6120 +34 ☔ View full report in Codecov by Sentry. |
|
# Conflicts: # sdk/src/callback_signer.rs # sdk/src/cose_sign.rs # sdk/src/openssl/ec_signer.rs # sdk/src/openssl/ed_signer.rs # sdk/src/openssl/temp_signer_async.rs # sdk/src/signer.rs # sdk/src/store.rs
…cRawSignerAdapter
There are still some WASM test failures
/// | ||
/// By pre-querying the value for the signing certificate, the value can be | ||
/// cached which will reduce load on the certificate authority, as | ||
/// recommended by the C2PA spec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mandatory in 2.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
No description provided.