Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add RawSigner trait to c2pa-crypto (derived from c2pa::Signer) #716

Merged
merged 35 commits into from
Dec 11, 2024

Conversation

scouten-adobe
Copy link
Collaborator

No description provided.

@scouten-adobe scouten-adobe self-assigned this Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 80.74180% with 135 lines in your changes missing coverage. Please review.

Project coverage is 80.59%. Comparing base (2a65756) to head (1d9e7a8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/cose_sign.rs 4.76% 40 Missing ⚠️
sdk/src/signer.rs 60.25% 31 Missing ⚠️
internal/crypto/src/raw_signature/signer.rs 77.38% 19 Missing ⚠️
internal/crypto/src/openssl/signers/rsa_signer.rs 86.13% 14 Missing ⚠️
sdk/src/utils/test_signer.rs 85.71% 11 Missing ⚠️
...nternal/crypto/src/openssl/signers/ecdsa_signer.rs 90.90% 6 Missing ⚠️
internal/crypto/src/p1363.rs 84.61% 6 Missing ⚠️
internal/crypto/src/openssl/cert_chain.rs 83.33% 3 Missing ⚠️
...ernal/crypto/src/openssl/signers/ed25519_signer.rs 94.00% 3 Missing ⚠️
sdk/src/utils/test.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   80.71%   80.59%   -0.12%     
==========================================
  Files         117      117              
  Lines       31554    31540      -14     
==========================================
- Hits        25468    25420      -48     
- Misses       6086     6120      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scouten-adobe scouten-adobe marked this pull request as draft December 6, 2024 03:42
@scouten-adobe
Copy link
Collaborator Author

scouten-adobe commented Dec 6, 2024

Work in progress: I plan, as part of this PR, to move the signer implementations in to c2pa_crypto. This part moves most of the Signer trait into c2pa_crypto (here known as RawSigner, since it only implements the core signature algorithm).

More to come tomorrow …

@scouten-adobe scouten-adobe marked this pull request as ready for review December 10, 2024 03:50
///
/// By pre-querying the value for the signing certificate, the value can be
/// cached which will reduce load on the certificate authority, as
/// recommended by the C2PA spec.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mandatory in 2.x

Copy link
Collaborator

@mauricefisher64 mauricefisher64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@scouten-adobe scouten-adobe merged commit 52124e5 into main Dec 11, 2024
28 of 30 checks passed
@scouten-adobe scouten-adobe deleted the move-raw-signer branch December 11, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants