Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

Parent Ingredient JSON #123

Merged
merged 3 commits into from
May 4, 2023
Merged

Parent Ingredient JSON #123

merged 3 commits into from
May 4, 2023

Conversation

gpeacock
Copy link
Contributor

@gpeacock gpeacock commented May 3, 2023

  • fix bug where ingredient thumbnails were not generated
    Ingredient fixes and improvements
  • an ingredient.json file or folder can now be passed on the command line --parent option.
  • if a folder is passed as an ingredient, the tool will look for an ingredient.json fle in that folder.
  • fix --parent is no longer relative to the --manifest path

gpeacock added 2 commits May 2, 2023 23:33
* fix bug where ingredient thumbnails were not generated
* an ingredient.json file or folder can now be passed on the command line --parent option.
* if a folder is passed as an ingredient, the tool will look for an ingredient.json fle in that folder.
* fix --parent is no longer relative to the --manifest path
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2023

Codecov Report

Merging #123 (e4608a7) into main (14ba719) will increase coverage by 1.50%.
The diff coverage is 90.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   81.30%   82.80%   +1.50%     
==========================================
  Files           3        3              
  Lines         369      378       +9     
==========================================
+ Hits          300      313      +13     
+ Misses         69       65       -4     
Impacted Files Coverage Δ
src/main.rs 83.05% <90.00%> (+2.37%) ⬆️

identifiers are relative to ingredient.json location
Update integration test
@dyro dyro self-requested a review May 4, 2023 19:33
Copy link
Contributor

@dyro dyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean!

@gpeacock gpeacock merged commit 56199ca into main May 4, 2023
@gpeacock gpeacock deleted the gpeacock/parent_json branch May 4, 2023 20:11
scouten-adobe pushed a commit to contentauth/c2pa-rs that referenced this pull request Dec 10, 2024
* Ingredient improvements and fixes
* fix bug where ingredient thumbnails were not generated
* an ingredient.json file or folder can now be passed on the command line --parent option.
* if a folder is passed as an ingredient, the tool will look for an ingredient.json fle in that folder.
* fix --parent is no longer relative to the --manifest path
* Set correct base path for ingredient_path json files
identifiers are relative to ingredient.json location
Update integration test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants