-
Notifications
You must be signed in to change notification settings - Fork 37
(IGNORE) Fix link to nightly build docs in README.md #142
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
=======================================
Coverage 83.91% 83.91%
=======================================
Files 3 3
Lines 373 373
=======================================
Hits 313 313
Misses 60 60 ☔ View full report in Codecov by Sentry. |
Use relative URL to correctly point to docs tree in branch when relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a change to the nightly build link to that it points to the NB README file in the current branch instead of hard-coding the path to the main
branch. This appears to work as I intended in this PR branch.
If you're OK with the change, 👍 to merge.
@scouten-adobe Your change still uses a relative URL. It needs to be an absolute URL for it to work from https://opensource.contentauthenticity.org/docs/c2patool/#nightly-builds which is the whole reason for this PR in the first place. Also, wouldn't we always want to link to the file in the main branch? The main branch should always have the current/approved documentation; if there's a WIP branch, e.g. for a PR, then the link might temporarily go to the current README.md instead of the one in the branch, but that seems like an edge case that could easily be ignored during PR review. Also, I don't have the ability to merge a PR in this repo, even if approved. :-( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok with me as long as @scouten-adobe approves. I think I heard you discussing this.
Changes in this pull request
Unfortunately, the relative link is broken when the doc is rendered on the doc site: https://opensource.contentauthenticity.org/docs/c2patool/#nightly-builds.
Change to absolute URL fixes it.
Also added colon to UTC time, per Adobe style guide.