Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

Add trust and verification options to c2pa_tool #168

Merged
merged 6 commits into from
Mar 14, 2024

Conversation

mauricefisher64
Copy link
Contributor

Changes in this pull request

This PR adds support to configure trust features including trust anchors, allowed lists, trust store configuration and verification options.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 76.10%. Comparing base (3d34beb) to head (2eff902).

Files Patch % Lines
src/main.rs 40.00% 30 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   83.95%   76.10%   -7.85%     
==========================================
  Files           3        3              
  Lines         374      406      +32     
==========================================
- Hits          314      309       -5     
- Misses         60       97      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@crandmck crandmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some minor edits to the README.

Also, the example files are missing:

  • sample/trust_anchors.pem
  • sample/allowed_list.pem
  • sample/store.cfg

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@crandmck
Copy link
Collaborator

crandmck commented Mar 13, 2024

Also @mauricefisher64 we should update the Usage section to add the new trust sub-command and options. I'd probably just mention them in the main section and tnen link down to the new section for details. I can edit the README directly in your branch if you want me to do that.

DONE

Copy link
Contributor

@dyro dyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean 👍

src/main.rs Show resolved Hide resolved
@crandmck crandmck self-requested a review March 14, 2024 17:55
@mauricefisher64 mauricefisher64 merged commit effdb8d into main Mar 14, 2024
10 checks passed
@mauricefisher64 mauricefisher64 deleted the trust_enablement branch March 14, 2024 19:28
scouten-adobe pushed a commit to contentauth/c2pa-rs that referenced this pull request Dec 10, 2024
…#168)

* Add trust and verification options to c2pa_tool

* fix formatting

* Fix typo

* Sample files

* README clarification and formatting

* Make example commands consistent, fix table column width, add xref link, etc

---------

Co-authored-by: Rand McKinney <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants