Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

(MINOR) Add HTTP source option for trust config #174

Merged
merged 5 commits into from
Apr 30, 2024
Merged

(MINOR) Add HTTP source option for trust config #174

merged 5 commits into from
Apr 30, 2024

Conversation

dkozma
Copy link
Contributor

@dkozma dkozma commented Apr 30, 2024

Changes in this pull request

  • Adds support for passing URLs for the trust configuration
  • Adds support for passing the trust configuration values as environment variables
  • Adds tests
  • Update the README

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@dkozma dkozma requested review from gpeacock and dyro April 30, 2024 16:14
@dkozma dkozma changed the title Add http trust config Add HTTP source option for trust config Apr 30, 2024
gpeacock
gpeacock suggested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the bit about subcommands. The c2patool doesn't support subcommands so we need to remove comments about that.

README.md Outdated Show resolved Hide resolved
dyro
dyro reviewed Apr 30, 2024
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@dkozma dkozma requested review from dyro and gpeacock April 30, 2024 17:13
@dkozma dkozma changed the title Add HTTP source option for trust config (MINOR) Add HTTP source option for trust config Apr 30, 2024
gpeacock
gpeacock approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to revisit how trust is implemented as a subcommand, but that is orthogonal to supporting urls in addition to paths, so I'm ok with this.

@dkozma dkozma merged commit 699b63f into main Apr 30, 2024
10 checks passed
@dkozma dkozma deleted the add-http-trust-config branch April 30, 2024 18:34
scouten-adobe pushed a commit to contentauth/c2pa-rs that referenced this pull request Dec 10, 2024
feat: Add HTTP source option for trust config (contentauth/c2patool#174)
c35457a 
* Add URL support for trust configuration settings
* Add file tests
* Add URL tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dyro dyro dyro approved these changes

@gpeacock gpeacock gpeacock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkozma @gpeacock @dyro