Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

Remove integration tests for now due to extraneous binaries #178

Merged
merged 4 commits into from
May 24, 2024

Conversation

dkozma
Copy link
Contributor

@dkozma dkozma commented May 23, 2024

Changes in this pull request

Give a narrative description of what has been changed.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@dkozma dkozma requested a review from dyro May 23, 2024 21:31
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.18%. Comparing base (e978cc1) to head (ff5ddaf).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   44.18%   44.18%           
=======================================
  Files           7        7           
  Lines         722      722           
=======================================
  Hits          319      319           
  Misses        403      403           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dyro dyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but we should keep the trust config tests at the bottom of the file.

tests/integration.rs Show resolved Hide resolved
@dkozma dkozma merged commit bff9c5e into main May 24, 2024
10 checks passed
@dkozma dkozma deleted the remove-integration-tests branch May 24, 2024 14:50
scouten-adobe pushed a commit to contentauth/c2pa-rs that referenced this pull request Dec 10, 2024
…uth/c2patool#178)

* Remove integration tests for now due to extraneous binaries
* Remove `bin` key
* Add comment about defaults
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants