Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

Fetch remote manifests for --info #75

Merged
merged 6 commits into from
Sep 22, 2022
Merged

Conversation

gpeacock
Copy link
Contributor

Changes in this pull request

Now fetches remote manifests for --info
better message when remote manifest fetch fails

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Merging #75 (1f3e6d8) into main (966c900) will decrease coverage by 0.98%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   73.83%   72.85%   -0.99%     
==========================================
  Files           4        4              
  Lines         279      291      +12     
==========================================
+ Hits          206      212       +6     
- Misses         73       79       +6     
Impacted Files Coverage Δ
src/info.rs 63.15% <60.00%> (-5.74%) ⬇️
src/main.rs 65.83% <0.00%> (+0.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@mauricefisher64 mauricefisher64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gpeacock gpeacock merged commit 66cba79 into main Sep 22, 2022
@gpeacock gpeacock deleted the gpeacock/fix_remote_info branch September 22, 2022 17:08
scouten-adobe pushed a commit to contentauth/c2pa-rs that referenced this pull request Dec 10, 2024
* Better message when fail to fetch remote manifest

* Add info integration tests

* Update sdk to get remote manifest data

* info not found integration test

* fix manifest size report for remote
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants