This repository has been archived by the owner on Dec 11, 2024. It is now read-only.
allows clients to output manifest report to specified directory #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 72.88% 78.79% +5.91%
==========================================
Files 4 5 +1
Lines 295 382 +87
==========================================
+ Hits 215 301 +86
- Misses 80 81 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
- supports `detailed` flag when writing - organizes thumbnails in a directory named for the manifest in which it appears - updates manifest extension to `.json`
gpeacock
reviewed
Dec 1, 2022
gpeacock
reviewed
Dec 1, 2022
gpeacock
suggested changes
Dec 1, 2022
There was a problem hiding this comment.
This looks good. I requested a couple of changes.
PS can add PSD and other ingredient types that will have different thumbnails formats than the ingredient. Also, if a PNG ingredient doesn't have transparency, we will use a jpeg thumbnail since it is smaller.
dyro
commented
Dec 2, 2022
gpeacock
approved these changes
Dec 2, 2022
scouten-adobe
pushed a commit
to contentauth/c2pa-rs
that referenced
this pull request
Dec 10, 2024
…entauth/c2patool#91) * allows clients to output manifest report to specified directory * appeases clippy * implements feedback * supports `detailed` flag when writing * organizes thumbnails in a directory named for the manifest in which it appears * updates manifest extension to `.json` * accounts for thumbnail title having different extension from thumbnail data * simplifies add extension to ingredient thumbnail file name Co-authored-by: Dylan Ross <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
This PR allows clients to output the manifest report, including its various thumbnails, to a user specified directory on the file system. This will be especially useful for clients who want to extract the thumbnails from the manifest. Here's an example of the new functionality:
The above command will write the manifest and its thumbnail contents to the
reportdirectory. Here's an example of the output:I went back on forth on a few different ways to organize all the thumbnails. Let me know if you have any suggestions on the directory structure!
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.