Fix Link resolution on localized content #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlitvakb
force-pushed
the
dl/fix-localized-link-resolution
branch
from
58eb162 to
8b12408
Compare
dlitvakb
force-pushed
the
dl/fix-localized-link-resolution
branch
from
8b12408 to
f57dbb7
Compare
jsdalton
approved these changes
Oct 4, 2016
| def replace_children(res, object) | ||
| object.each do |name, potential_objects| | ||
| if localized_entry?(object, name, potential_objects) |
There was a problem hiding this comment.
Should the logic in this block be broken out into its own method (e.g. detect_localized_objects)? replace_children is starting to get a bit complicated with this addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing contentful/contentful_middleman#95