Fix has_many_nested for models in modules #125
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of many has_many_nested methods break when the model is in a namespace like this:
The problem is caused by use of
to_s.underscore
, which returns 'contentfulmodels/page' and breaks lots of variables.I have fixed it by using
to_s.demodulize.underscore
.I would like to add tests for this, but all the tests in this part of the code base seem to be failing with VCR errors that I can't fix without being able to recreate the test space.