Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loss of configured default_locale #130

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Fix loss of configured default_locale #130

merged 1 commit into from
Oct 11, 2019

Conversation

MattFenelon
Copy link
Contributor

@MattFenelon MattFenelon commented May 23, 2019

Some of the configuration values are being lost because ContentfulModel::Management is created without the configured values in some locations. ContentfulModel::Migrations::ContentTypeFactory.find, for example, creates an instance of ContentfulModel::Management with no configuration.

This change centralises the configuration into ContentfulModel::Management.initialize so that all instances use the configured values, such as default_locale.

Losing default_locale causes errors when a space is configured without the default en-US locale.

Some of the configuration values are being lost because
ContentfulModel::Management is created without the configured values
in some locations. ContentfulModel::Migrations::ContentTypeFactory.find,
for example, creates an instance of ContentfulModel::Management with no
configuration.

This change centralises the configuration into
ContentfulModel::Management.initialize so that all instances use the
configured values, such as default_locale.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants