feat: superscipt and subscript support to rich text editor [TOL-30] #1280
Conversation
✅ Deploy Preview for contentful-field-editors ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -61,7 +61,16 @@ import { RichTextEditor } from '@contentful/field-editor-rich-text'; | |||
| }; | |||
|
|
|||
| const initialValue = JSON.parse(window.localStorage.getItem('initialValue')) || undefined | |||
| const [field, mitt] = useMemo(() => createFakeFieldAPI(mock => mock, initialValue), []); | |||
| const [fakeField, mitt] = useMemo(() => createFakeFieldAPI(mock => mock, initialValue), []); | |||
| // Overriding mark validation here to show subscript and superscript marks | |||
There was a problem hiding this comment.
By default we don't show the superscript and subscript marks but showing in the preview so doing an override here
| @@ -0,0 +1,52 @@ | |||
| import { createFakeFieldAPI } from '@contentful/field-editor-test-utils'; | |||
There was a problem hiding this comment.
@MayaGillilanContentful testing the logic for validating marks in these unit tests
| const findMarkViaToolvar = (mark: MARKS) => cy.findByTestId(`${mark}-toolbar-button`); | ||
| const toggleMarkViaToolbar = (mark: MARKS) => cy.findByTestId(`${mark}-toolbar-button`).click(); | ||
|
|
||
| it(`hides ${MARKS.SUBSCRIPT} and ${MARKS.SUPERSCRIPT} marks if not explicitly allowed`, () => { |
There was a problem hiding this comment.
@MayaGillilanContentful also some cypress tests here for checking the showing/hiding logic
| @@ -61,7 +61,16 @@ import { RichTextEditor } from '@contentful/field-editor-rich-text'; | |||
| }; | |||
|
|
|||
| const initialValue = JSON.parse(window.localStorage.getItem('initialValue')) || undefined | |||
| const [field, mitt] = useMemo(() => createFakeFieldAPI(mock => mock, initialValue), []); | |||
| const fieldValidations = JSON.parse(window.localStorage.getItem('fieldValidations')) || undefined | |||
There was a problem hiding this comment.
Should this default to undefined and not []?
There was a problem hiding this comment.
I'm falling back to undefined as I think local storage uses null by default. Then later on it will fallback to whatever value the mock gives us if it has one. I don't want to hard code this to []
Adding subscript and superscript support to rich text editor
@contentful/rich-text-types