Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Webpack v5 in Storybook #2193

Merged
merged 1 commit into from
Sep 5, 2022
Merged

chore(deps): Webpack v5 in Storybook #2193

merged 1 commit into from
Sep 5, 2022

Conversation

denkristoffer
Copy link
Collaborator

Purpose of PR

I think this is necessary for #2187 because Storybook's Webpack v4 loader is causing issues.

  • Upgrades to Webpack v5
  • Upgrades Storybook to latest

Approach

Adds an explicit webpack dependency as well as a Yarn resolution for Storybook's use of Webpack. It looks like Webpack v5 will be the default in Storybook v7 (currently in alpha) so once we upgrade to that we can get probably get rid of these again.

Risks

I don't think there are any risks, we're not using Webpack as a direct dependency.

@denkristoffer denkristoffer requested review from a team, mshaaban0 and Lelith as code owners September 5, 2022 13:33
@denkristoffer denkristoffer requested a review from massao September 5, 2022 13:33
@vercel
Copy link

vercel bot commented Sep 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
forma-36 ✅ Ready (Inspect) Visit Preview Sep 5, 2022 at 1:36PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2022

⚠️ No Changeset found

Latest commit: 509fb01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
f36-components 79.1 KB (+0.02% 🔺) 1.6 s (+0.02% 🔺) 816 ms (-10.18% 🔽) 2.4 s
Modern 0 B (+100% 🔺) 0 ms (+100% 🔺) 267 ms (+31.96% 🔺) 267 ms
Module 0 B (+100% 🔺) 0 ms (+100% 🔺) 304 ms (+56.98% 🔺) 304 ms
UMD 79.11 KB (+0.02% 🔺) 1.6 s (+0.02% 🔺) 664 ms (+57.01% 🔺) 2.3 s

@denkristoffer denkristoffer merged commit 0e646ff into main Sep 5, 2022
@denkristoffer denkristoffer deleted the chore/webpack-5 branch September 5, 2022 13:55
denkristoffer added a commit to Wake1st/forma-36 that referenced this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants