Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EntityListItem): skeleton loader height, drag handle, and card wrapping #2989

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

cf-remylenoir
Copy link
Collaborator

@cf-remylenoir cf-remylenoir commented Jan 31, 2025

Purpose of PR

Fixes issues with the EntityListItem component where:

  • The skeleton loader height would be too big
  • The drag handle would shrink when texts are too long
  • The badge and the action menu were cut off when texts were too long
- Before After
Action menu (missing) basic-wrap-before basic-wrap-after
Skeleton, badge, drag handle drag-wrap-before drag-wrap-after

Additional updates

The component is now wrapped with a max width in the story to showcase the truncation and wrapping effects and prevent further regression.

Further work down the road

There is still a mismatch between the component styling and iconography with the Figma library that we need to revisit.

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: 2be8531

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@contentful/f36-entity-list Patch
@contentful/f36-accordion Patch
@contentful/f36-asset Patch
@contentful/f36-autocomplete Patch
@contentful/f36-badge Patch
@contentful/f36-button Patch
@contentful/f36-card Patch
@contentful/f36-collapse Patch
@contentful/f36-copybutton Patch
@contentful/f36-core Patch
@contentful/f36-datetime Patch
@contentful/f36-datepicker Patch
@contentful/f36-drag-handle Patch
@contentful/f36-empty-state Patch
@contentful/f36-forms Patch
@contentful/f36-icon Patch
@contentful/f36-header Patch
@contentful/f36-list Patch
@contentful/f36-menu Patch
@contentful/f36-modal Patch
@contentful/f36-navbar Patch
@contentful/f36-note Patch
@contentful/f36-notification Patch
@contentful/f36-pagination Patch
@contentful/f36-pill Patch
@contentful/f36-popover Patch
@contentful/f36-skeleton Patch
@contentful/f36-spinner Patch
@contentful/f36-table Patch
@contentful/f36-tabs Patch
@contentful/f36-text-link Patch
@contentful/f36-tooltip Patch
@contentful/f36-typography Patch
@contentful/f36-components Patch
@contentful/f36-image Patch
@contentful/f36-avatar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Feb 3, 2025 9:54am

@cf-remylenoir cf-remylenoir self-assigned this Jan 31, 2025
@cf-remylenoir cf-remylenoir marked this pull request as ready for review January 31, 2025 16:01
@cf-remylenoir cf-remylenoir requested review from damann and a team as code owners January 31, 2025 16:01
Copy link

github-actions bot commented Jan 31, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 112.34 KB (-0.05% 🔽) 2.3 s (-0.05% 🔽) 186 ms (-0.15% 🔽) 2.5 s
Module 110.92 KB (-0.07% 🔽) 2.3 s (-0.07% 🔽) 215 ms (-0.93% 🔽) 2.5 s

@cf-remylenoir cf-remylenoir merged commit f1ade97 into main Feb 3, 2025
17 checks passed
@cf-remylenoir cf-remylenoir deleted the ufo-1608-entity-list-item branch February 3, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants