fix: ignore unsupported marks

contentful · Dec 17, 2018 · 1757331 · 1757331
1 parent 7a464fa
commit 1757331
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/packages/rich-text-from-markdown/src/__test__/real-world.md b/packages/rich-text-from-markdown/src/__test__/real-world.md
@@ -24,7 +24,7 @@ __This is bold text__
 
 _This is italic text_
 
-~~Strikethrough~~
+~~Strikethrough is not supported~~
 
 
 ## Blockquotes

diff --git a/packages/rich-text-from-markdown/src/__test__/real-world.test.ts b/packages/rich-text-from-markdown/src/__test__/real-world.test.ts
@@ -29,7 +29,7 @@ describe('rich-text-from-markdown', () => {
         block(BLOCKS.PARAGRAPH, {}, text('This is bold text', mark('bold'))),
         block(BLOCKS.PARAGRAPH, {}, text('This is italic text', mark('italic'))),
         block(BLOCKS.PARAGRAPH, {}, text('This is italic text', mark('italic'))),
-        block(BLOCKS.PARAGRAPH, {}, text('Strikethrough', mark(undefined))),
+        block(BLOCKS.PARAGRAPH, {}, text('Strikethrough is not supported')),
         block(BLOCKS.HEADING_2, {}, text('Blockquotes')),
         block(BLOCKS.QUOTE, {}, block(BLOCKS.PARAGRAPH, {}, text('Blockquotes'))),
         block(BLOCKS.HEADING_2, {}, text('Lists')),

diff --git a/packages/rich-text-from-markdown/src/index.ts b/packages/rich-text-from-markdown/src/index.ts
@@ -114,9 +114,13 @@ async function mdToRichTextNode(node: MarkdownNode, fallback: FallbackResolver):
       // for example: **_Hello_, world!**
       // this a markdown node here that's why we use children
       nodeValue = node.children ? node.children[0].value : node.value;
-      marks.push({
-        type: markTypeFor(node),
-      });
+
+      const markType = markTypeFor(node);
+      if (markType) {
+        marks.push({
+          type: markTypeFor(node),
+        });
+      }
     }
     return {
       nodeType: nodeType,