Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**Feature:** Allow autoFocus for the TextArea #988

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

mpotomin
Copy link
Contributor

Summary

Passes autoFocus prop to the TextArea
#983

To be tested

Me

  • No error or warning in the console on localhost:6060

Tester 1

  • Things look good on the demo.

@mpotomin mpotomin requested review from fabien0102 and TejasQ April 23, 2019 16:01
@mpotomin mpotomin self-assigned this Apr 23, 2019
Copy link
Contributor

@TejasQ TejasQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a deeper issue here and that is that Textareas are not extensible for accessibility or other userland purposes. Can we augment the scope of this PR a bit and fix #983 in here?

@mpotomin
Copy link
Contributor Author

@TejasQ Could you please be more specific regarding which exactly props should be passed to the TextArea? Shall I pass all from TextArea's MDN page?

@TejasQ
Copy link
Contributor

TejasQ commented Apr 24, 2019

@mpotomin – according to the issue, I mean let's just spread all incoming props onto the underlying textarea, like we do on Input.

@mpotomin mpotomin requested a review from TejasQ April 24, 2019 09:12
@mpotomin mpotomin merged commit af7f769 into master Apr 24, 2019
@TejasQ TejasQ deleted the feature/autofocus-textarea branch April 24, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants